Fix comparison of absolute path with filesystem using relative prefix #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intoeetive
reviewed
Apr 12, 2024
| @@ -1142,6 +1142,11 @@ protected function removePathPrefix($path) | |||
| { | |||
| $prefix = $this->getPathPrefix(); | |||
|
|
|||
| // If path is absolute but prefix is not shift the prefix | |||
There was a problem hiding this comment.
IDK what the initial issue was, so please forgive me if I'm getting it wrong.
I don't remember what the prefix can be - can it be like C:\ on Windows? If yes, this code might be problematic.
Otherwise, looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.