Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable uploading file into RTE (CKEditor) field with drag&drop in CP and Channel Form #4171

Open
wants to merge 19 commits into
base: 7.dev
Choose a base branch
from
Open

Enable uploading file into RTE (CKEditor) field with drag&drop in CP and Channel Form #4171

wants to merge 19 commits into from

Conversation

intoeetive
Copy link
Contributor

This is follow-up of #4170 but because it's adding new Action and new setting for field, might be more suitable for minor release.

The changes:

  • adds new setting for "default upload location" for each RTE field. Now the file manager will be initially opened for that location (when invoked from RTE) and that directory will be used for direct file upload using button or drag&drop. If directory is not accessible, the first accessible directory will be used.
  • add new button "upload image from computer" into CKEditor. If turned on, the users can upload using that button and also with drag&drop, otherwise this functionality is disabled
  • enables uploading into RTE using CKEditor in Channel Forms

intoeetive and others added 17 commits March 20, 2024 10:38
@intoeetive
added plugins to CKEditor:
9243ce8 
- insert image by URL
- find and replace
@intoeetive
fix source editing
0675111
@intoeetive
use correct icon
5f332ef
@Yulyaswan
fixed labels for modal wimdows, changed find button color
fe75935
@intoeetive
enable drag&drop upload into CKEditor
b3667f0 
in progress, directory_id is hardcoded
@intoeetive
remove what does not belong here
18025f0
@Yulyaswan
added style for dark theme
9e95e92
@intoeetive
fix how regex for RTE configs are built
05528b6
@intoeetive
change the default tags allowed in source mode
853a270
@Yulyaswan
changed styles for powered by ckeditor label
3be74a8
@Yulyaswan
make image visible when cke is on focus
f884c89
@intoeetive
file upload buttons
cb168e9
@intoeetive
icon
76f3e05
@Yulyaswan
Merge branch 'feature/7.x/rte-more-plugins' into feature/7.x/dnd-rte-…
0e87738 
…image-upload

# Conflicts:
#	js-src/ckeditor5-build-classic/src/ckeditor.js
#	themes/ee/asset/javascript/src/fields/rte/ckeditor/ckeditor.js
#	themes/ee/asset/javascript/src/fields/rte/ckeditor/ckeditor.js.map
#	themes/ee/asset/javascript/src/fields/rte/rte.js
@intoeetive
move script to file add-on
d256ddb
@intoeetive
Merge branch 'feature/7.x/dnd-rte-image-upload' of github.com:Express…
2f94a97 
…ionEngine/ExpressionEngine into feature/7.x/dnd-rte-image-upload

# Conflicts:
#	themes/ee/asset/javascript/src/fields/rte/ckeditor/ckeditor.js.map
@intoeetive
fix the frontend upload call
5900e45
@intoeetive intoeetive added the enhancement New feature or request label Mar 25, 2024
@intoeetive intoeetive added this to the 7.5.0 milestone Mar 25, 2024
@TomJaeger TomJaeger modified the milestones: 7.5.0, 7.5.x Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
7.5.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@intoeetive @TomJaeger @Yulyaswan