Fix issue #4037 where uploading a file could remove EXIF data

[bryannielsen]

When an image is uploaded to an Upload Destination using a local filesystem adapter we will move the file in a way that preserves any EXIF data present. Note that if any transformations are performed upon upload the EXIF data may be removed if the image processing library does not support EXIF.

[intoeetive]

Did not test through different environments, but the code looks good to me

Does not seem to work though :) The upload tests are failing

[bryannielsen]

@intoeetive tests are passing now, I'm also hoping that @jcogs-design can chime in when he has a chance and see if this resolves the original issue.

[jcogs-design]

Apologies for delay in responding to this.
All seems to work OK here.
One observation though. The edits to Upload.php include this comment

     * Move the file to the final destination
     *
     * If we have an UploadDestination and it is not a local filesystem
     * we will write the stream of data to that remote filesystem
     *
     * Otherwise we will act locally to avoid potentially losing EXIF data
     * To deal with different server configurations we'll attempt to use
     * copy() first.  If that fails we'll use move_uploaded_file().
     * One of the two should reliably work in most environments
     */

From what testing I've done it looks like the Flysystem file utilities preserve EXIF data (so if you upload an EXIF bearing file to an EE7 Cloud File S3 folder and then download it again, the downloaded file still has EXIF data attached). So possibly if this is true also for the Flysystem Local Adapter (and presumably it will be) then you maybe can avoid having the split local vs. remote code, and simply use Flysystem throughout.

HTH
🐾

[bryannielsen]

@jcogs-design thanks for taking a look!

That's interesting about what you're observing with remote filesystems and EXIF data. The current code is using Flysystem for the local filesystem as well as remote ones but that seems to be what causes the loss of EXIF data locally. Did your environment that you were testing on have EXIF support compiled into PHP?

[jcogs-design]

I'm not sure why basic file operations in php would remove EXIF regardless of whether php is built with the EXIF library installed.