-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monolog Logging #4041
Draft
intoeetive
wants to merge
420
commits into
7.dev
Choose a base branch
from
feature/7.x/monolog
base: 7.dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Monolog Logging #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build-tools/build.json # system/ee/ExpressionEngine/Tests/bootstrap.php # system/ee/installer/controllers/wizard.php # system/ee/legacy/libraries/Core.php # tests/cypress/support/config/config.php
ExpressionEngine 7.3.9
ExpressionEngine 7.3.10
ExpressionEngine 7.3.11
# Conflicts: # build-tools/build.json # system/ee/ExpressionEngine/Tests/bootstrap.php # system/ee/installer/controllers/wizard.php # system/ee/legacy/libraries/Core.php # tests/cypress/support/config/config.php
# Conflicts: # build-tools/build.json # system/ee/ExpressionEngine/Controller/Members/Members.php # system/ee/ExpressionEngine/Tests/bootstrap.php # system/ee/ExpressionEngine/View/members/pending.php # system/ee/installer/controllers/wizard.php # system/ee/legacy/libraries/Core.php # tests/cypress/support/config/config.php
…ded by the functionality
# Conflicts: # build-tools/build.json # system/ee/ExpressionEngine/Addons/grid/ft.grid.php # system/ee/ExpressionEngine/Tests/bootstrap.php # system/ee/installer/controllers/wizard.php # system/ee/legacy/libraries/Core.php # tests/cypress/support/config/config.php
ExpressionEngine 7.3.12
* update GH actions * back to latest chrome * experimentalMemoryManagement * no message * split updater test
…tab-performance Improve Structure Tab Performance
…r-gmmktime-fix Fixed gmmktime bug in mod_channel_calendar.php where strings were being passed instead of ints
…hannel Resolved #3973 Where not all valid channel options we're presented to save a channel entry into.
…put-hook adds `response_send_output` hook
…ember-ft Refactor Member fieldtype to extend Relationship and add extension hooks
# Conflicts: # build-tools/build.json # composer.lock # system/ee/ExpressionEngine/Tests/bootstrap.php # system/ee/installer/controllers/wizard.php # system/ee/legacy/libraries/Core.php # tests/cypress/support/config/config.php # vendor-bin/php-scoper/composer.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to implement Monolog as logging library,
ee('Logger')
service,logger.php
config file, new Logging settings and new Log manager.A lot of things really, I recorded a 15 min video for PacketTide team where I rather awkwardly explain what has been done. https://drive.google.com/file/d/1WMAg5t3C4U5Q9Oj0-_QAk_Ae7XMjyufd/view?usp=sharing
It needs to be reviews and possible some adjustments made before it can be released.
Also need to mention I went through several iterations on how the config is built, that included team discussions, and the current one is probably optimal, considering logging is really targeting tech people as primary audience