Improved CP performance issue with relationships in grids #3966 #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for relationships NOTE this is quick and dirty prototype it's relying on URL segment to return the component - we need a better check it's still including the component for all requests (just not sent to browser if deferred) - we need to only build component data if we need those it does not support Grids yet once we get proof of concept, we need to get those things fixed
# Conflicts: # system/ee/ExpressionEngine/Addons/relationship/ft.relationship.php # system/ee/ExpressionEngine/Addons/relationship/views/publish.php
|
@Yulyaswan I made necessary updates to support Grid and Fluid fields. What I noticed however is that if you have a Relationship in Grid (and also regular Relationship field) the click on "edit" in Grid (but not in Regular field) is processed twice, so the AJAX is performed twice. Could you please check why this would be happening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved CP performance issue with relationships in grids
Resolved #3966
In this PR, we are loading JSON after clicking the button for the relationship React component if the 'Defer field initialization' option is used.
It works for single relationship field
@intoeetive could you please have a look for next items: