-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluid Field Group Improvements #4030
Fluid Field Group Improvements #4030
Conversation
if(defined('CLONING_MODE') && CLONING_MODE === true && !isset($fluid_field_data[$id])) { | ||
$clonedField = ee('Model')->get('fluid_field:FluidField')->filter('id', $id)->first(); | ||
$group_key = 'group_' . $clonedField->group; | ||
}else if (isset($fluid_field_data[$id])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is not PSR-12 compatible (needs spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryannielsen also there are code conflicts to resolve
ExpressionEngine 7.4.0
Merge pull request #4054 from ExpressionEngine/7.dev
ExpressionEngine 7.4.2
Merge pull request #4101 from ExpressionEngine/7.dev
Add new fixed_order and order template parameters to fluid field group's {fields} tag Resolve some issues with Fluid Field Groups in Live Preview
2fedf34
to
1b2d529
Compare
images/uploads/index.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file have been removed? @bryannielsen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I think I missed it in the rebase. I'll put it back 👍
@bryannielsen Is there anything I can do to help with this? I'm happy to test things in a vanilla build if that's helpful. |
@pyrobob83 that would be much appreciated if you're willing to do some testing! |
@bryannielsen FWIW, this seems to be working as I'd expect it without any adverse effects. I made sure I had multiple field groups available to my fluid field, made sure I had several blocks setup with fully populated content in an entry and noted the presentation on the frontend. Then I manually replaced the 3 core files in the PR - I just overwrote the entire files to makes sure I didn't screw up something:
Then re-checked the presentation and it was identical so proceeded to add a new field to my field groups and those did indeed show up and became usable in existing entries and I was able to reorder the fields inside the field groups and have the order update accordingly on the Publish screen. As far as I can see, this is what we need, though appreciate there could be some edge-case scenarios I'm not testing that could surface issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled and tested those changes, no issues.
This PR addresses several issues and improvements for handling field groups within a fluid field.
Documentation PR: ExpressionEngine/ExpressionEngine-User-Guide#866