Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added possibility to change field label using Publish Layouts #3881

Open
wants to merge 6 commits into
base: 7.dev
Choose a base branch
from
Open

Added possibility to change field label using Publish Layouts #3881

wants to merge 6 commits into from

Conversation

Yulyaswan
Copy link
Collaborator

@Yulyaswan Yulyaswan commented Nov 8, 2023 •
edited by intoeetive
Loading

@Yulyaswan Yulyaswan added this to the 7.x milestone Nov 8, 2023
@intoeetive
Merge branch '7.dev' into feature/7.x/rename-field-title
ef77fb7 
# Conflicts:
#	system/ee/language/english/channel_lang.php
#	themes/ee/asset/javascript/src/cp/channel/layout.js
@intoeetive
add backend for custom field labels in layout
3d33ffb
@intoeetive intoeetive changed the title Added possibility to change fields title in Layout Added possibility to change field label using Publish Layouts Nov 9, 2023
@intoeetive
Copy link
Contributor

@Yulyaswan I added the backend part, but I think we need a UX update.

  1. It is currently not clear that the field name can be edited. I suggest maybe showing pencil icon on hover? (like we do for copying field short name on entry page). Or maybe change mouse to text cursor, not hand.
  2. If you press enter in the input, the page gets submitted, but the changes are not saved. We need to prevent that, and make pressing Enter work same as 'blur' currently (and not submit page)

@intoeetive intoeetive added the enhancement New feature or request label Nov 9, 2023
@Yulyaswan
Copy link
Collaborator Author

@intoeetive I changed as you asked. Please check

@intoeetive intoeetive marked this pull request as ready for review November 15, 2023 08:35
intoeetive
intoeetive approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@intoeetive intoeetive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yulyaswan loving it! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intoeetive intoeetive intoeetive approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
7.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yulyaswan @intoeetive