add markers to identify the partial name #3700
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intoeetive
commented
Mar 11, 2024
| @@ -403,6 +403,8 @@ public function parse(&$str, $is_embed = false, $site_id = '', $is_layout = fals | |||
| 'Snippet "' . $variable . '"' | |||
| ); | |||
|
|
|||
| $replace = $this->addSourceMarker($replace, $variable, $added_globals['template_type']); | |||
There was a problem hiding this comment.
Because this has potential to break templates (e.g. comment inside a comment, or when partial is used as a parameter for HTML tag), we need more precise control here.
At the minimum, we need to add config override and only add markers when it's set. Ideally, we might want to be able to control this on template level, like we do with front-end editing tags.
Or make it better code overall, aware of context and not break things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2867