Example for color contrast #3526
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed before, I created this PR (Draft) to improve color contrast. I used the
light snow themeas an scss file to change colors. This work is based on Wave app and suggestion from it. I mainly used HEX colors (not variables), because, in my opinion, we don't need to do this kind of work for different themes, like dark or pink.If @TomJaeger will approve these changes, then it will make sense to create a new theme, something like
"contrast-color theme"usingcp-styles/app/styles/themes/_theme-light-snow.scssas an example for colors.IMPORTANT: Don't merge this PR anywhere. After merging this PR will break our Snow theme, and we don't want this. This is just an example.
github issue 1590