Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved #3463 where "choose wisely" was a poor choice #3520

Open
wants to merge 1 commit into
base: 7.dev
Choose a base branch
from

Conversation

bryannielsen
Copy link
Contributor

We are changing the blank select state from "Choose wisely" to "Please select" by introducing a new please_select language variable. We are leaving in place the old choose_wisely language variable in case it is being used by others but this can be removed in the next major release.

@bryannielsen bryannielsen added the enhancement New feature or request label Jun 14, 2023
@bryannielsen bryannielsen added this to the 7.3.4 milestone Jun 14, 2023
@intoeetive
Copy link
Contributor

I have heard a lot of times from agencies that with even a little change in the UI (like the labels names differently) is requiring them to instruct the editors again.

So I don't think we should not just change the label for everyone, especially in patch release. I think we need to make it into system configuration variable (with "Choose wisely" being set for existing installs and "Please select" for new installs), and for the select fields maybe even make configurable in each field settings

@bryannielsen
Copy link
Contributor Author

bryannielsen commented Jun 15, 2023

I think that's a good policy in general but I do feel like this is really poorly worded and this change can only make it clearer for editors. I can remember my first encounter with this "Choose wisely" label caused me to second guess whether it was safe to interact with this input.

@intoeetive
Copy link
Contributor

I think we need @TomJaeger decide on this one

@intoeetive intoeetive modified the milestones: 7.3.4, 7.3.5 Jun 16, 2023
@intoeetive intoeetive modified the milestones: 7.3.5, 7.4.0 Jun 20, 2023
@intoeetive
Copy link
Contributor

@TomJaeger we need your opinion here. I think we need to:

  • make this text configurable as override in config file
  • keep using 'Choose Wisely' for existing installs so that user would not be confused with change
  • use 'Please select' for new installs

@intoeetive intoeetive changed the base branch from 7.dev to release/7.4.0 November 8, 2023 14:14
TomJaeger
TomJaeger previously approved these changes Nov 10, 2023
@intoeetive intoeetive modified the milestones: 7.4.0, 7.x Jan 30, 2024
Base automatically changed from release/7.4.0 to 7.dev February 14, 2024 15:11
@bryannielsen bryannielsen dismissed TomJaeger’s stale review February 14, 2024 15:11

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants