Fixes many typos in the core #3487
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJaeger
reviewed
Jun 5, 2023
TomJaeger
reviewed
Jun 5, 2023
system/ee/ExpressionEngine/Controller/Utilities/SyncConditionalFields.php
Show resolved
Hide resolved
TomJaeger
reviewed
Jun 5, 2023
| @@ -9,7 +9,7 @@ | |||
| </span> | |||
| <?php endif; ?> | |||
| <?php if ($addlink) : ?> | |||
| <a href="<?=$addlink?>" class="dropdown__item-button button button--secondary button--xsmall"<?=$addlinkAttibutes?>><i class="fal fa-plus"></i><span class="hidden"><?=lang('btn_create_new') . ' ' . $text?></span></a> | |||
| <a href="<?=$addlink?>" class="dropdown__item-button button button--secondary button--xsmall"<?=$addlinkAttributes?>><i class="fal fa-plus"></i><span class="hidden"><?=lang('btn_create_new') . ' ' . $text?></span></a> | |||
There was a problem hiding this comment.
Not sure we can change this one? @matthewjohns0n
There was a problem hiding this comment.
I did update this everywhere, but since it is a shared form view, we probably cant make this change.
|
After discussing this with @TomJaeger, we're taking this out of the 7.3.0 release since it requires a bit more manual checking of the changes. |
intoeetive
reviewed
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.