Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added visual indication of future entry date and past expiration date in Entry Manager; #2912 #3469

Open
wants to merge 1 commit into
base: 7.dev
Choose a base branch
from
Open

Added visual indication of future entry date and past expiration date in Entry Manager; #2912 #3469

wants to merge 1 commit into from

Conversation

intoeetive
Copy link
Contributor

Added visual indication of future entry date and past expiration date in Entry Manager; closes #2912

Based on #1603 by @mithra62

This PR adds appropriate hourglass icon with a tooltip:

  • to entry date column ONLY if entry date is in future
  • to expiration date column ONLY if expiration is in the past
    image

@intoeetive intoeetive added the enhancement New feature or request label May 30, 2023
@intoeetive intoeetive added this to the 7.3.5 milestone May 30, 2023
@intoeetive intoeetive requested a review from TomJaeger May 30, 2023 07:50
@intoeetive intoeetive modified the milestones: 7.3.7, 7.3.8 Jul 12, 2023
@intoeetive
Copy link
Contributor Author

@TomJaeger because this is UI change, we need your approval

@intoeetive intoeetive modified the milestones: 7.3.9, 7.3.10 Jul 28, 2023
@bryannielsen bryannielsen modified the milestones: 7.3.11, 7.3.12 Aug 14, 2023
matthewjohns0n
matthewjohns0n previously approved these changes Aug 28, 2023
View reviewed changes
@intoeetive intoeetive dismissed matthewjohns0n’s stale review September 6, 2023 13:12

@TomJaeger said he does not like the hourglass :(

@intoeetive intoeetive modified the milestones: 7.3.12, 7.x Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewjohns0n matthewjohns0n matthewjohns0n left review comments

@TomJaeger TomJaeger Awaiting requested review from TomJaeger

At least 1 approving review is required to merge this pull request.

Assignees

@TomJaeger TomJaeger

Labels
enhancement New feature or request
Projects
None yet
Milestone
7.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@intoeetive @matthewjohns0n @TomJaeger @bryannielsen