save CP theme to member profile #2198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toggle themes in cycle
TomJaeger
reviewed
Aug 4, 2022
| @@ -212,6 +217,20 @@ public function dismissBanner() | |||
|
|
|||
| ee()->output->send_ajax_response(['success']); | |||
| } | |||
|
|
|||
| /** | |||
| * Dismiss post-update banner from CP homepage, until next update | |||
There was a problem hiding this comment.
Comment should be updated.
TomJaeger
reviewed
Aug 4, 2022
| public function switchTheme() | ||
| { | ||
| $member = ee()->session->getMember(); | ||
| $member->cp_theme = ee('Request')->isPost() ? ee('Request')->post('theme') : ee('Request')->get('theme'); |
There was a problem hiding this comment.
Can we validate theme is in an array of allowed themes?
There was a problem hiding this comment.
The validation is done in javascript file
revert icon change
matthewjohns0n
requested changes
Aug 15, 2022
| return true; | ||
| } | ||
|
|
||
| private function addCpThemeToMember() |
There was a problem hiding this comment.
We're going to need to move this to a new update file.
|
I just saw after posting this review that this branch is still a draft, so I'm sure you knew that already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toggle themes in cycle
based on conversation: https://packettide.slack.com/archives/C030JTF1ZFB/p1659621964566149