-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core_boot hook is not called when using CLI commands #2846
Comments
@litzinger sorry for the delay on this! Looking at the order of execution here, I wonder if this could be expected behavior.
I think it might be better to add separate extension hook (e.g. Thoughts? |
Yeah, I think an |
@litzinger where do you think it's best to have the hook placed? I can think of running it just after |
Having an instance of the command would be interesting and potentially helpful. |
Added `cli_boot` and `cli_before_handle` extension hook to run on each CLI request; #2846
Description of the problem
The
core_boot
hook does not appear to be getting called when using the CLI commands. This was an issue a few versions ago and I thought it was resolved, but it appears to be happening again.How To Reproduce
Put a core_boot extension hook into any add-on. Then run a command from the CLI. Note that the core_boot hook is not called. In this case Publisher is creating several class instances that are later used during the import process, but since the hook is not called, the classes do not exist and the import is failing.
Environment Details:
Additional context
The text was updated successfully, but these errors were encountered: