Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for the upcoming version #482

Merged
merged 3 commits into from
Oct 24, 2017
Merged

Conversation

XVincentX
Copy link
Member

@XVincentX XVincentX commented Oct 24, 2017

While I was writing the changelog as well the documentation for the upcoming version I noticed two small bugs:

  1. When querying the WebAPI for schemas with key and type specified, the result should be a single object and not an array.

  2. I found out all predefined schemas aren't being published — now they are.

Connects #483

@codecov
Copy link

codecov bot commented Oct 24, 2017

Codecov Report

Merging #482 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #482      +/-   ##
=========================================
- Coverage    91.5%   91.5%   -0.01%     
=========================================
  Files         219     219              
  Lines        9401    9400       -1     
=========================================
- Hits         8602    8601       -1     
  Misses        799     799
Impacted Files Coverage Δ
test/rest-api/schemas.test.js 100% <100%> (ø) ⬆️
lib/schemas/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fdfe2...89bd0be. Read the comment docs.

@XVincentX XVincentX force-pushed the feature/1.3_final_touches branch 2 times, most recently from 3263397 to 89bd0be Compare October 24, 2017 18:26
Copy link
Contributor

@DrMegavolt DrMegavolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XVincentX XVincentX merged commit 1d4330a into master Oct 24, 2017
@XVincentX XVincentX deleted the feature/1.3_final_touches branch October 24, 2017 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants