switch from custom stringFormat to fmtlib #2769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
- Coverage 64.62% 64.57% -0.05%
==========================================
Files 104 104
Lines 22239 22155 -84
Branches 10911 10849 -62
==========================================
- Hits 14371 14306 -65
+ Misses 5626 5610 -16
+ Partials 2242 2239 -3 ☔ View full report in Codecov by Sentry. |
|
How about we just wait for C++20 as min requirement and use std::format straight away? Or code it in a way to use std::format if using C++20 so there is one less dependency? |
kmilos
reviewed
Oct 18, 2023
neheb
force-pushed
the
fmt
branch
7 times, most recently
from
1ac41a6
to
db8dbda
Compare
kmilos
reviewed
Oct 23, 2023
kmilos
reviewed
Oct 23, 2023
kmilos
reviewed
Oct 24, 2023
kmilos
reviewed
Nov 14, 2023
kmilos
reviewed
Nov 14, 2023
kmilos
reviewed
Nov 14, 2023
neheb
force-pushed
the
fmt
branch
9 times, most recently
from
43e31a2
to
51b29fe
Compare
neheb
force-pushed
the
fmt
branch
17 times, most recently
from
e204e8b
to
2efbdf3
Compare
|
remaining error needs to be fixed by @kevinbackhouse I think. |
kmilos
previously approved these changes
Nov 27, 2023
|
Rebased. |
The latter helps to avoid wrong format errors and is simpler to use. Will be replaced by std::format once C++20 becomes mandatory. Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
|
Rebased. |
Signed-off-by: Rosen Penev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter helps to avoid wrong format errors and is simpler to use. Will be replaced by std::format once C++20 becomes mandatory.