-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Public Delta Lake writer #2329
Conversation
Thank you to @siddharth-gulia for the original work on this! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage ? 79.06%
=======================================
Files ? 473
Lines ? 55143
Branches ? 0
=======================================
Hits ? 43597
Misses ? 11546
Partials ? 0
|
Oh one question I had is if it should be kept as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, but main thing is to keep the io related changes in daft/io
and rely on dynamic imports when io is invoked
Follow-up on #2304 with additional cleanup, parameters, and testing of the Delta Lake writing functionality, now set to be a public API with this PR!
This PR also renames
read_delta_lake
toread_deltalake
, providing a deprecation warning for the old nameTodo before merging: