Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] fill_nan and not_nan expressions #2313

Merged
merged 4 commits into from
Jun 14, 2024
Merged

[FEAT] fill_nan and not_nan expressions #2313

merged 4 commits into from
Jun 14, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented May 28, 2024

Adds expressions for fill_nan and not_nan

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 80.34188% with 23 lines in your changes missing coverage. Please review.

Project coverage is 63.51%. Comparing base (f99fcd8) to head (a2fddef).
Report is 2 commits behind head on main.

Current head a2fddef differs from pull request most recent head 0d8ad16

Please upload reports for the commit 0d8ad16 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2313      +/-   ##
==========================================
+ Coverage   63.48%   63.51%   +0.02%     
==========================================
  Files         906      908       +2     
  Lines      101891   102008     +117     
==========================================
+ Hits        64687    64786      +99     
- Misses      37204    37222      +18     
Files Coverage Δ
daft/expressions/expressions.py 93.09% <100.00%> (+0.07%) ⬆️
src/daft-core/src/array/ops/float.rs 100.00% <100.00%> (ø)
src/daft-core/src/python/series.rs 94.52% <100.00%> (+0.06%) ⬆️
src/daft-dsl/src/functions/float/mod.rs 100.00% <100.00%> (ø)
src/daft-dsl/src/python.rs 91.82% <100.00%> (+0.10%) ⬆️
daft/series.py 91.83% <85.71%> (-0.08%) ⬇️
src/daft-core/src/series/ops/float.rs 76.92% <85.71%> (+10.25%) ⬆️
src/daft-dsl/src/functions/float/not_nan.rs 64.00% <64.00%> (ø)
src/daft-dsl/src/functions/float/fill_nan.rs 53.84% <53.84%> (ø)

... and 6 files with indirect coverage changes

@colin-ho colin-ho merged commit b861f4c into main Jun 14, 2024
43 checks passed
@colin-ho colin-ho deleted the colin/fill-nan branch June 14, 2024 17:45
sunaysanghani pushed a commit to sunaysanghani/Daft that referenced this pull request Jun 18, 2024
Adds expressions for `fill_nan` and `not_nan`

Todo: 
- add expression for `fill_na`, which is a convenience method for doing
fill_null and fill_nan together, see:
Eventual-Inc#571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant