Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch and feature request were meant for #103. But it turned out to be way too complex. Plus, the typescript grammar we use sucks and parses code incorrectly. Fixing it would be a lot of work. Thus, I have done all of the refactoring and preparations for this feature beforehand and put them in this request. Finally, I decided to temporarily ditch typescript and fall back to a custom ECMAScript 2023 grammar that I will write myself.
Reviewing commit by commit, you will see these changes:
access_modifier
node to the API, including C#common
bindings.skip
not implemented nodes,pass
through them without parsing, orthrow
an error to terminate the entire execution.Do note, however, that for ECMAScript 2023 our goal is to implement the syntax only, not the feature set and standard library. Even more, we don't have to implement the entire syntax now, but iteratively add features to it as we add new Crosslight nodes.
I'll merge after approval from the reviewers, but keep the branch for further work on the lexer and parser for ECMAScript 2023.