Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorings #104

Merged
merged 5 commits into from
Nov 26, 2023
Merged

Refactorings #104

merged 5 commits into from
Nov 26, 2023

Conversation

mcmikecreations
Copy link
Collaborator

This branch and feature request were meant for #103. But it turned out to be way too complex. Plus, the typescript grammar we use sucks and parses code incorrectly. Fixing it would be a lot of work. Thus, I have done all of the refactoring and preparations for this feature beforehand and put them in this request. Finally, I decided to temporarily ditch typescript and fall back to a custom ECMAScript 2023 grammar that I will write myself.

Reviewing commit by commit, you will see these changes:

  1. a62f24d Added the access_modifier node to the API, including C# common bindings.
  2. 3834250 Rewrote typescript visitor behavior. Now, children to visit should be specified explicitly to skip parsing for nodes that are not yet implemented.
  3. 607fd75 Added an option to still parse all children, regardless if there is a handler for them.
  4. aaa217b Added an ability to either skip not implemented nodes, pass through them without parsing, or throw an error to terminate the entire execution.
  5. 0f8424c Added empty files for the ECMAScript 2023 implementation.

Do note, however, that for ECMAScript 2023 our goal is to implement the syntax only, not the feature set and standard library. Even more, we don't have to implement the entire syntax now, but iteratively add features to it as we add new Crosslight nodes.

I'll merge after approval from the reviewers, but keep the branch for further work on the lexer and parser for ECMAScript 2023.

@mcmikecreations mcmikecreations added bug Something isn't working enhancement New feature or request labels Nov 14, 2023
@mcmikecreations mcmikecreations self-assigned this Nov 14, 2023
Copy link
Collaborator

@SergiyIvan SergiyIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mcmikecreations mcmikecreations merged commit 9ea1059 into master Nov 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants