add setting to hide tray (menubar for macos) #9624
Open
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Eugeny any thoughts on this? |
Eugeny
reviewed
Jun 17, 2024
|
Sorry for the delay, I'm completely overwhelmed with work right now. Looks good, left 2 notes |
|
No worries, thanks for taking the time. I made changes to accomodate those notes. Another issue that I am seeing is that the 'showTray' config is not added to the config file if it doesn't exist (and is therefore out-of-sync with the toggle). Is there a standard way of handling the case where a config option is added if it is not already set? |
|
No, unfortunately the main process doesn't have access to the same merged "defaults + user settings" object, so all access to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4955 (I know it's marked as completed, but it was never implemented from what I can see)