Feat #6518: add disconnect current tab hotkey and context menu item #8589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, explicitly disconnecting a tab should keep it open! (otherwise, the user could have just closed it instead) |
Eugeny
requested changes
Jun 16, 2023
|
Thank's for you feedback. I just made the two needed changes :D |
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Eugeny, I hope you're doing well.
I tried to add the feature asked in the issue #6518. This PR adds a hotkey
disconnect-taband aDisconnectitem in the tab context menu.I also tried to make this feature fits well with the configurable behavior on session end. Actually, disconnecting the current tab overrides the selected behavior :
keep-> no effect, offer reconnectionclose&auto-> keep the tab open and offer reconnectionWhat is your opinion on this ? Do you think it would be more appropriate to create two distinct options if the tab behavior is
close? (DisconnectandDisconnect & keep tab openfor example)Feel free to ask if any changes are needed :)
Resolve #6518