Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vibrancy (fixes #5) #383

Merged
merged 4 commits into from
Aug 2, 2018
Merged

Vibrancy (fixes #5) #383

merged 4 commits into from
Aug 2, 2018

Conversation

Eugeny
Copy link
Owner

@Eugeny Eugeny commented Aug 2, 2018

No description provided.

@Eugeny Eugeny merged commit cc9c66c into master Aug 2, 2018
@Eugeny Eugeny deleted the vibrancy branch August 2, 2018 17:34
@DRSDavidSoft
Copy link

Is Vibrancy working at the moment? If so, could you please add an a screenshot?

@Eugeny
Copy link
Owner Author

Eugeny commented Aug 6, 2018

Yes, but not in the released builds yet. Vibrancy is available for macOS and transparency is available for macOS & Windows.

I'm working on getting vibrancy on Windows and transparency on Linux at the moment.

Vibrancy:

screenshot 2018-08-06 at 10 35 19

Transparency:

screenshot 2018-08-06 at 10 35 51

@DRSDavidSoft
Copy link

Nice. If you could make it look like this on macOS, it'd be awesome!

@Eugeny
Copy link
Owner Author

Eugeny commented Aug 6, 2018

It does look this way with an appropriate wallpaper and background tint disabled:

image

I've left some background tint in, because a lot of bright wallpapers make the terminal text unreadable without it. But it's all configurable with user CSS of course

@Eugeny
Copy link
Owner Author

Eugeny commented Aug 6, 2018

With the tint fully disabled:

image

@DRSDavidSoft
Copy link

@Eugeny This is amazing! Wish the same effect could be achieved on Windows. Can you take a look at 23phy/electron-acrylic? here's a sample.

@Eugeny
Copy link
Owner Author

Eugeny commented Aug 6, 2018

Currently looking at https://github.com/arkenthera/electron-vibrancy as it seems to be more stable

@DRSDavidSoft
Copy link

@Eugeny Awesome. Should Windows' "blur-behind" be in a new issue instead of this one?

@Eugeny
Copy link
Owner Author

Eugeny commented Aug 9, 2018

image

I'll be pushing windows vibrancy support into master soon

@DRSDavidSoft
Copy link

@Eugeny This is so cool! ❤️ I wish it could get more blurred, so we could achieve the same effect as running on macOS

@sylveon
Copy link
Contributor

sylveon commented Sep 30, 2018

I don't like the electron-vibrancy package because it forces you to disable shadows on Windows and it makes the window look weird.

@sylveon
Copy link
Contributor

sylveon commented Sep 30, 2018

My PR to vscode for the effect does have a more intense blur on Windows: microsoft/vscode#52707

@Eugeny
Copy link
Owner Author

Eugeny commented Oct 1, 2018

@sylveon does your solution also work with window snapping? (win key + arrows)?

@sylveon
Copy link
Contributor

sylveon commented Oct 1, 2018

Yes, you can see me playing with them here https://www.youtube.com/watch?v=K2qw0fKGE60

@smlombardi
Copy link

I've seen multiple posts on this for months, anyone have any idea if it will ever see the light of day?

@Eugeny
Copy link
Owner Author

Eugeny commented Oct 1, 2018

@smlombardi it's long released, were now talking about an alternative implementation by @sylveon

@smlombardi
Copy link

@Eugeny I can use this in my themes for Insiders now?
Are there docs for us theme authors as to how to integrate transparency in our themes?

@Eugeny
Copy link
Owner Author

Eugeny commented Oct 5, 2018

@smlombardi all you need is to have a transparent background-color on the body. If vibrancy is enabled by the user, it will have the .vibrant class.

@smlombardi
Copy link

So how does one enable vibrancy?

If vibrancy is enabled by the user

@Eugeny
Copy link
Owner Author

Eugeny commented Oct 5, 2018

@sylveon now in master - thank you so much!

@Eugeny
Copy link
Owner Author

Eugeny commented Oct 5, 2018

@smlombardi Settings -> Appearance -> Vibrancy
image

@sylveon
Copy link
Contributor

sylveon commented Oct 5, 2018

Awesome! A few tips tho:

  • As I've noted in the configuration option on vscode, the fluent appearance is really buggy at times (video, I've made the editor background fully transparent to highlight it better) so not sure if you want to ship that as default, an optional setting to enable it or making the vibrancy a dropdown with different appearances is probably better. It's nothing your app can fix, it's something in DWM.
  • macOS doesn't needs electron-vibrancy anymore, as electron natively supports it. See the vibrancy property of the browser window create options, as well as window.setVibrancy
  • On Linux, it's also possible to do, if you can afford the loss of hardware accelerated rendering (which a small app like Terminus should be fine with, after all vscode without hardware acceleration works well on my lower end laptop). Note that in this case, you can only enable transparency and it's up to the user's compositor to render the blur effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants