Add support for windows 10 mutiple windows and fix various tab/window related bugs #1249
Conversation
…ure we don't save the state of our open tabs innapropriately
…Also fix issue where closing main window would remove all tabs from saved tab state
…he first recovered console.. I'm sure there's a better way.
…pen in a specific location
| @@ -39,7 +39,6 @@ const argv = parseArgs(process.argv, process.cwd()) | |||
|
|
|||
| if (!app.requestSingleInstanceLock()) { | |||
| app.quit() | |||
| process.exit(0) | |||
There was a problem hiding this comment.
Any reason for this? The process needs to exit quickly after sending the second-instance message
There was a problem hiding this comment.
Looking at all documentation for app.requestSingleInstanceLock() everything said to use app.quit(). app.quit() calls beforeunload and unload event handlers before exiting. Doesn't look like any of those handlers are in use right now but they may be added in the future.
I just felt that the process.exit(0) was redundant after calling app.quit().
I couldn't find much documentation on calling process.exit in an electron application other than process.exit is a Node API, so I would assume that it may not do all the right things with regard to an Electron application.
I'll happily add it in if app.quit() isn't enough!
There was a problem hiding this comment.
Maybe app.exit(0) is a good solution?
|
Would also love this. Just started using Terminus in Win10 with WSL2 and would really love to be able to have multiple instances going across multiple Desktops spaces. |
|
Is this available on MacOS ? |
Fixes #509
Fixes #1089
There is some changes in there that I'm not sure follow your intended behaviors for the application. Let me know if there's anything you want changed or that i'm simply misunderstanding.