Add uhd cmake #16
Closed
Add uhd cmake #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LES_DIR if provided (default value is "lib${LIB_SUFFIX}/cmake/"). Tested to work with GR's new FindUHD.cmake (as a daisy-chained "find_package(UHD ...)") as well as directly.
…were actually used; UHDConfig*.cmake are not always allowed to use CACHE variables, thus the use of ENV.
Closed
This was referenced Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added in the final tweaks to get this system working. I'll do the same on the GR side right after this one. These changes will work no matter if "find_package(UHD ...)" is issued from within GR or otherwise, and takes care of the condition that "find_package(gnuradio ...)" is issued -before- the UHD find_package, and thus that GR's FindUHD.cmake is called first. The ENV variables allow FindUHD.cmake to determine that UHDConfig* were actually used, and thus to determine whether to do a check itself (or, not). What fun! - MLD