Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed squaring in ndPAC: values are now normalized [0, 1] #9

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

raphaelvallat
Copy link
Contributor

See #8

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   91.27%   91.28%           
=======================================
  Files          14       14           
  Lines        1066     1067    +1     
  Branches      159      159           
=======================================
+ Hits          973      974    +1     
  Misses         48       48           
  Partials       45       45           
Impacted Files Coverage Δ
tensorpac/methods/meth_pac.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a3b3f...ea54686. Read the comment docs.

@EtienneCmb
Copy link
Owner

Thanks @raphaelvallat,

Good idea of improving the doc of the ps. However, this is not the phase of the high-frequency that is required, but the phase of the amplitude of the high-frequency. Can you make the changes? And for the input arguments, I propose pha and pha_amp

@raphaelvallat
Copy link
Contributor Author

Just made the changes!

@EtienneCmb EtienneCmb merged commit 579a53c into EtienneCmb:master Mar 18, 2020
@EtienneCmb
Copy link
Owner

Parfait chef ! Merci !

Closes #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants