Avoid in-place normalization in ndpac

[raphaelvallat]

Hello @EtienneCmb!

I was playing around with amazing TensorPac today, and I noticed that the tensorpac.methods.ndpac() function is doing an in-place normalization of the amplitude. I understand this is probably to limit memory usage but I think this is not optimal for users, like myself, who prefer to use directly the "raw" functions in tensorpac.methods rather than the Pac main class.

Let me know what you think! I am also happy to add this change to the documentation changelog.

A+ :-)

[codecov]

Codecov Report

Merging #6 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop     #6   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            2      2           
  Lines          117    117           
======================================
  Hits           117    117

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a257d56...3adfa20. Read the comment docs.

[EtienneCmb]

@raphaelvallat, nice to see you here,

I do agree with you. However, I realized that the develop branch is way behind the master branch. Could you please make your modifications on the master branch?

Merci mec !

++

[k-jerbi]

Bravo les gars, vous êtes au taquet.

-K

On Sun, Mar 15, 2020 at 03:23 Etienne Combrisson ***@***.***> wrote: @raphaelvallat <https://github.com/raphaelvallat>, nice to see you here, I do agree with you. However, I realized that the develop branch is way behind the master branch. Could you please make your modifications on the master branch? Merci mec ! ++ — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHDOCDIZFI4OHKWT2OPYPNLRHR66BANCNFSM4LKIHF2Q> .

-- Prof Karim Jerbi Canada Research Chair in Computational Neuroscience and Cognitive Neuroimaging Associate Professor, Department of Psychology, Université de Montréal (UdeM) Associate Member, MILA (Quebec Artificial Intelligence Institute) Director of Centre UNIQUE (Union Neurosciences & Intelligence Artificielle - Quebec) [unique.quebec] Co-Director of UoM Magnetoencephalography (MEG) Core Facility Associate Director of the functional Imaging Unit (UNF - Unité de Neuroimagerie Fonctionnelle) Co-Director of the Canadian MEG Consortium Member of MILA, BRAMS, CRIUGM, CRIUSMM, CRBLM, NeuroQAM & Lab PhysNum (CRM) Personal Website: http:https://www.karimjerbi.com LinkedIn Profile: http:https://www.linkedin.com/in/karimjerbi Twitter account: https://twitter.com/karimjerbineuro Google Scholar Profile: http:https://scholar.google.com/citations?user=FvXuJbUAAAAJ&hl=fr