Remove top level import of matplotlib in utils.py #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import statements have been added to the PSD and PeakLockedTF classes as these were the only classes using matplotlib that did not already include all required import statements
|
Hi @tylerbrunette, sorry for the (very) delayed answer. Thanks for the edits :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import statements have been added to the PSD and PeakLockedTF classes
as these were the only classes using matplotlib that did not already
include all required import statements
These changes allow importing tensorpac without having matplotlib installed. An import error will only occur when you attempt to use one of the plotting functions in utils.py instead of immediately on module import.