Adding digital ocean cluster connection setup #9388
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzlamateen
requested changes
Dec 6, 2023
| bash ./scripts/setup_aws.sh $EKS_AWS_ACCESS_KEY_ID $EKS_AWS_ACCESS_KEY_SECRET $AWS_REGION $CLUSTER_NAME | ||
| elif [[ "$CLOUD_PROVIDER" == "do" ]]; then | ||
| bash ./scripts/setup_do.sh $DO_API_TOKEN $CLUSTER_NAME | ||
| else |
There was a problem hiding this comment.
I just think, the default case can be aws. Like if CLOUD_PROVIDER is missing then assume its running for aws. This will ensure all our existing deployments are not broken / does not needs any change.
There was a problem hiding this comment.
I have updated this as suggested.
hanzlamateen
requested changes
Dec 20, 2023
|
|
||
| import S3Provider from './s3.storage' | ||
|
|
||
| const MAX_ITEMS = 1 |
There was a problem hiding this comment.
I dont think this is required
| import S3Provider from './s3.storage' | ||
|
|
||
| const MAX_ITEMS = 1 | ||
| const CFFunctionTemplate = ` |
There was a problem hiding this comment.
I dont think this is required
hanzlamateen
requested changes
Jan 5, 2024
| : `${config.aws.cloudfront.domain}/${this.bucket}` | ||
|
|
||
| originURLs = [this.cacheDomain] | ||
|
|
||
| private bucketAssetURL = | ||
| config.server.storageProvider === 's3' | ||
| public bucketAssetURL = |
There was a problem hiding this comment.
All the 's3-do' specific check in this file should be moved to S3DOStorageProvider. The class variable should be updated based on DO in constructor of it.
muradkhateeb78
commented
Jan 10, 2024
| export class S3DOProvider extends S3Provider { | ||
| constructor() { | ||
| super() | ||
| this.bucketAssetURL = 'https://etherealengine-static-resources.sfo2.digitaloceanspaces.com' |
There was a problem hiding this comment.
Need to remove this.
Updated pod schema to include imagePullSecrets, pods-helper to return this alongside current information.
barankyle
force-pushed
the
feat/setup-DO-cluster
branch
from
08664f2
to
b6df1cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has the code changes for setting up DO specific cluster configurations for EE.
References
closes #insert number here
QA Steps