This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Remove side effects from components #10979
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
reviewed
Aug 16, 2024
| SourceComponent.entitiesBySourceState[src].set(entities) | ||
| } | ||
| useLayoutEffect(() => { | ||
| const source = sourceComponent.value |
There was a problem hiding this comment.
if the source changes after the component has been created, this will no longer have the same value. we should just move this line inside the returned function
There was a problem hiding this comment.
Oh if the source can change this is setup incorrectly altogether and won't clean up properly, good catch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps