IR-2721: Zendesk integration #10416
Merged
IR-2721: Zendesk integration #10416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jose-galvan
requested review from
jonathan-casarrubias,
HexaField,
hanzlamateen and
aditya-mitra
|
How can I test this? Can you please provide steps? |
@hanzlamateen, I updated the QA steps. |
hanzlamateen
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Overall seems to be working fine. Though:
- Need to pass
VITE_ZENDESK_ENABLED&VITE_ZENDESK_KEYin all files as done in following PR
Added VITE_FEATHERS_STORE_KEY to Docker builds #10426 - @HexaField should this be done in core engine or a new project/module for zendesk?
Done |
|
This is fine to include in the core engine for now |
hanzlamateen
approved these changes
Jun 24, 2024
MbfloydIR
added a commit
that referenced
this pull request
Jun 24, 2024
* dev: (34 commits) ir 2253 fix project zip archiver (#10437) IR-2721: Zendesk integration (#10416) clearer delete scene argument id (#10440) fix editor tests (#10439) fix material removal errors due to missing source component (#10433) studio: ui feedback for loading a scene (#10404) fix material ParameterInput (#10429) update visibility to authoring layer (#10428) IR-2711: update default scene (#10399) clean up console log fix resources.json sorting not happening when it is regenerated fix styling for key value project settings (#10432) Added VITE_FEATHERS_STORE_KEY to Docker builds (#10426) IR 2148 Material Entities for All Meshes, Improved hashing logic, Plugin Components (#10209) Ir 2543 create prefab (#10384) feat(tooltip): make title from string to ReactNode to accept custom title (#10424) Update branch-build.yml (#10430) fix frustum culling calculation (#10418) show no results for unmatching query in hierarchy tree (#10415) Remove react-is hackfix install (#10425) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Zendesk widget integration
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps