Improving DUX more #10410
Merged
Improving DUX more #10410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still thinking about restricting by file type. I keep considering edge cases that start to include .css files and files I am trying to avoid tests from running. I think the issue is that we don't have a separate action for checking if the application builds. Vs our unit tests. So I might extract tests out. I am not sure. |
|
I have a plan to better cache the modules to work across workflows hopefully. Then I think I will have a specific unit tests workflow. Separate from ensuring build client works which will always run. |
|
Scratching plan and just fixing merge queue |
HexaField
approved these changes
Jun 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
* remove push action as it clashes with checks * test file type * I think this will actually fix the issue we saw * re add restricted file types * add yml * remove paths
MbfloydIR
added a commit
that referenced
this pull request
Jun 27, 2024
* dev: wip material instancing and ui fixes (#10450) Optimize-routing (#10465) IR-2719: Unify & unit-test all regex patterns at one place (#10444) IR-2824-Reinstate-original-publish-workflow-in-studio (#10462) remove bottom margin (#10464) Fix fog color and improve colorInput (#10463) change grid defaults (#10460) no cameraSystem without viewer (#10457) moving el.remove code to support safari (#10445) chore: Update thumbnailKey path in onNewScene function (#10454) fix drag and drop on file browser (#10448) Improving DUX more (#10410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From my research we were actually just missing an event on our branch-build that prevented merge queue from working.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps