Assets must populate from all projects you have perms for #10409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBelmes
requested review from
HexaField,
jose-galvan,
achen5671 and
dinomut1
HexaField
approved these changes
Jun 18, 2024
HexaField
requested changes
Jun 18, 2024
DanielBelmes
commented
Jun 26, 2024
HexaField
requested changes
Jun 27, 2024
…into IR-2666-Studio-No-assets-showing-up-in-Assets-Panel
…ttps:https://github.com/EtherealEngine/etherealengine into IR-2666-Studio-No-assets-showing-up-in-Assets-Panel
dinomut1
approved these changes
Jun 27, 2024
|
Will wait for @hanzlamateen to sign off on this |
hanzlamateen
previously requested changes
Jun 28, 2024
packages/server-core/src/media/static-resource/static-resource.hooks.ts
Outdated
Show resolved
Hide resolved
packages/server-core/src/user/identity-provider/identity-provider.hooks.ts
Outdated
Show resolved
Hide resolved
….hooks.ts Co-authored-by: Hanzla Mateen <[email protected]>
barankyle
reviewed
Jun 28, 2024
packages/server-core/src/hooks/resolve-projects-by-permission.ts
Outdated
Show resolved
Hide resolved
barankyle
approved these changes
Jun 28, 2024
HexaField
approved these changes
Jun 29, 2024
DanielBelmes
deleted the
IR-2666-Studio-No-assets-showing-up-in-Assets-Panel
branch
MbfloydIR
added a commit
that referenced
this pull request
Jul 2, 2024
* dev: (21 commits) show grid lines by default in studio (#10500) Fix xrui pointer input & improved follow camera (#10471) feat: zendesk widget in viewer app & custom button (#10494) fix the download project button (#10499) studio: titles of some elements on components are not properly displayed (camelcased or lowercased) (#10491) fix slider ui (#10490) add point light name (#10495) upload from assets panel (#10487) IR-2838-Studio-Click-Selection-Regression (#10479) Add better error to file-browser patch (#10489) Fixed issue with HLS streams not playing (#10485) IR-2810: Redesign Compress Menu (#10469) studio: fix context menu (#10475) fix(IR-2799): fix feature flags state (#10453) fix WebXR (#10484) IR-2727: Zendesk authentication (#10452) Assets must populate from all projects you have perms for (#10409) image convert modal (#10466) clean out userdata after initializing ecs data from gltfs (#10470) Material IO Fixes (#10480) ... # Conflicts: # packages/common/src/utils/getAllStringValueNodes.ts # packages/engine/src/avatar/systems/AvatarCameraInputSystem.ts # packages/spatial/src/camera/components/FollowCameraComponent.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So we have a lot of permissions considerations. Currently in this state we have removed the need for static resource read. Then we are building queries with all projects you have perms for if you don't supply an individual project in the query.
file&assetresource types/thumbnailsto/public/thumbnailssince they need to be public read access in s3/cloudfront or they'll be unreachable in deployments/public/thumbnailsfolder or that end with '.thumbnail.jpg' (scene thumbnails) are tagged as 'thumbnail'static_resource:writescope will automatically be given owner project permission for all projectsSubtasks Checklist
Breaking Changes
References
https://tsu.atlassian.net/browse/IR-2616
IR-2616
QA Steps