Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lit and Unlit modes implementation #10408

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Lit and Unlit modes implementation #10408

wants to merge 19 commits into from

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Jun 18, 2024

Summary

fixes the drop shadows in the application. The changes ensure that the drop shadows are correctly applied to mesh and model and primitive geom entities.

Subtasks Checklist

Breaking Changes

References

https://tsu.atlassian.net/browse/IR-2264

QA Steps

@aditya-mitra aditya-mitra changed the title Add isEditor in Editor2Page and fix drop shadows Lit and Unlit modes implementation Jun 20, 2024
@aditya-mitra aditya-mitra marked this pull request as draft June 20, 2024 17:27
@SYBIOTE
Copy link
Member Author

SYBIOTE commented Jul 1, 2024

for the lit - unlit implementation, I hide all light in unlit mode and turn on the lights when in any other mode
in unlit mode we add a temp ambient light to the scene and remove it when we are in any other mode

@SYBIOTE SYBIOTE marked this pull request as ready for review July 1, 2024 22:56
@SYBIOTE SYBIOTE requested a review from HexaField July 2, 2024 11:18
@SYBIOTE SYBIOTE requested a review from HexaField July 4, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants