Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file properties on context menu #10397

Merged
merged 9 commits into from
Jul 5, 2024
Merged

file properties on context menu #10397

merged 9 commits into from
Jul 5, 2024

Conversation

aditya-mitra
Copy link
Collaborator

Summary

Subtasks Checklist

Breaking Changes

References

closes part of https://tsu.atlassian.net/browse/IR-2624

Figma Design

QA Steps

image

Copy link
Collaborator

@CITIZENDOT CITIZENDOT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • triangle count, texture count and Author properties are missing (compared to design). is this intentional?
    image
  • fontFamily is Figtree in design
  • Just a minor UX issue (not much important):
    image
    When clicked Enter after typing a tag, it would be nice if that gets added. (just like clicking + button)

@aditya-mitra
Copy link
Collaborator Author

triangle count, texture count and Author properties are missing (compared to design). is this intentional?

The texture and triangle count need to be present in the model (static-resource). Currently we do not get this property from the API.
Added the author property.
image

fontFamily is Figtree in design

added

Just a minor UX issue (not much important):

added

@HexaField
Copy link
Member

FYI, we do have a field for triangle and texture count, the stats field, but we have not populated these yet.

See https://github.com/etherealengine/etherealengine/blob/dev/packages/server-core/src/media/static-resource/static-resource-helper.ts#L191

@CITIZENDOT CITIZENDOT added this pull request to the merge queue Jul 5, 2024
Merged via the queue into dev with commit e6b7315 Jul 5, 2024
25 checks passed
@CITIZENDOT CITIZENDOT deleted the ir-2624 branch July 5, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants