This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Added code to prevent default scene files being moved/deleted #10358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
suggested changes
Jun 11, 2024
That's fine with me too. Good idea about tying it to syncFileSystem. |
Since new scene creation runs off of default-project/public/scenes/default.gltf, if this file has been moved, scene creation will break. The backend now disallows moving, patching, or deleting anything in default-project when in a production environment, which is determined via !config.fsProjectSyncEnabled. Resolves IR-2566.
|
needs to be reimplemented around new CMS |
|
@HexaField did you mean to close this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since new scene creation runs off of default-project/public/scenes/default.gltf, if this file has been moved, scene creation will break. The backend now disallows moving or deleting this scene and its related files.
Resolves IR-2566.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps