Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IR-2164] Unit Test - Physics #10282

Merged
merged 96 commits into from
Jun 28, 2024
Merged

[IR-2164] Unit Test - Physics #10282

merged 96 commits into from
Jun 28, 2024

Conversation

heysokam
Copy link
Contributor

@heysokam heysokam commented May 30, 2024 •
edited
Loading

Summary

Subtasks Checklist

  • All Physics.ts Rapier->ECS APIs
  • All Physics.ts External APIs
  • RigidbodyComponent
  • ColliderComponent
  • CollisionComponent
  • TriggerComponent
  • TriggerSystem
  • PhysicsSystem

Breaking Changes

References

QA Steps

@heysokam heysokam self-assigned this May 30, 2024
@heysokam
Copy link
Contributor Author

@HexaField @DanielBelmes

  1. Are these tests going in the right direction?
  2. I have tests for like 35-40% of a single file, and its already at 700sloc. Should I subdivide this task into multiple PRs? It feels massive for a single one 🤔

HexaField
HexaField requested changes May 30, 2024
View reviewed changes
packages/spatial/src/physics/classes/Physics.test.ts Outdated Show resolved Hide resolved
packages/spatial/src/physics/classes/Physics.test.ts Outdated Show resolved Hide resolved
packages/spatial/src/physics/classes/Physics.test.ts Outdated Show resolved Hide resolved
packages/spatial/src/physics/classes/Physics.test.ts Outdated Show resolved Hide resolved
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
1bfc140
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
87e0891
@heysokam
tst: UnitTests for the Physics.ts API (phase 1)
bad2460
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
4f77360
@heysokam
tst: UnitTests for the Physics.ts API (phase 2)
f00d616
@heysokam
fix: RigidBodyComponent.enabledRotations allowed type coercion
4444028 
`RigidBodyComponent.onSet` allowed type modification/coercion when passing an array of `length === 3` that has incorrectly typed values.
This fix should stop `@ts-ignore` from accidentally modifying values that shouldn't be modified.
@heysokam
tst: UnitTests for RigidBodyComponent.ts (phase 0)
a60ab71
@heysokam
tst: UnitTests for ColliderComponent.tsx (phase 0)
45d88c4
@heysokam
tst: unitTests for CollisionComponent.ts
69f3d37
@heysokam
tst: Typo bugfix in ColliderComponent.test.tsx
a542160
@heysokam
tst: UnitTests for TriggerComponent.ts (phase 0)
66b0de8
@heysokam
tst: Files sketch for the Physics systems unit tests
b57c1d8
@heysokam
tst: UnitTests for the Physics.ts API (phase 3)
9e63efe
@heysokam
tst: UnitTests for the Physics.ts API (phase 4)
e91c31d
@heysokam
tst: UnitTests for the Physics.ts API (phase 5)
da8b616
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
5310d32
@heysokam
tst: UnitTests for the Physics.ts API (phase 6)
5737a88
@heysokam
doc: Update @todo tags in Physics.test.ts
4109504
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
c9877d3
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
a96fabe
@heysokam
tst: Bugfixes for setCollisionLayer tests at Physics.test.ts
dc4db83
@heysokam
tst: UnitTests for createColliderDesc at Physics.test.ts (phase 7)
6a2b2f4
@heysokam
tst: UnitTests for Physics.ts API (phase 8)
c8d13d0
@heysokam
tst: UnitTests for TriggerSystem (phase 3)
3390345
@heysokam
tst: Bugfixes in Physics.test.ts vectors and rotations asserts
dc3a53c
@heysokam
tst: UnitTests for Physics.drainCollisionEventQueue (phase 2)
c25c1b9
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
991dbd7
@heysokam
tst: UnitTests for Physics.drainCollisionEventQueue (phase 3)
3ff81aa
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
2005e9f
@heysokam
tst: UnitTests for PhysicsSystem.smoothKinematicPose:multiplier 0
105def1
@heysokam
tst: UnitTests for PhysicsSystem.smoothKinematicPose:multiplier !0
95c7af8
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
33f2dff
@heysokam
fmt: Simplify the PhysicsState drain* type declarations
929552a
@heysokam
tst: Add assertVecAnyApproxNotEq helper. Improve float assert logic
93e58ea
@heysokam
tst: Export assertRigidBodyComponentEqual for other tests
5b675ba
@heysokam
tst: UnitTests for PhysicsSystem.execute
eeb0519
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
f9822e9
@heysokam
tst: UnitTests for Physics.drainContactEventQueue
2476a9e
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
c09142e
@heysokam
fix: Hookstate CI/CD error
8638d38
@heysokam
tst: Add @todo note about TriggerSystem tests for onEnter/onExit
b20d320
@heysokam
Merge branch 'dev' into IR-2164-unit-test-physics
7cfb063
@heysokam heysokam marked this pull request as ready for review June 27, 2024 03:35
@HexaField HexaField self-requested a review June 28, 2024 04:58
@HexaField HexaField added this pull request to the merge queue Jun 28, 2024
Merged via the queue into dev with commit f38852e Jun 28, 2024
25 checks passed
@HexaField HexaField deleted the IR-2164-unit-test-physics branch June 28, 2024 07:06
MbfloydIR added a commit that referenced this pull request Jun 28, 2024
@MbfloydIR
Merge branch 'dev' into michael/IR-2665-triggers
8847400 
* dev:
  Reflection probes (#10458)
  standardize IR-Engine Deploy across dev,int,stg; IR-2698 (#10474)
  added scene helpers tools (#10477)
  fix loading screens (#10476)
  [IR-2164] Unit Test - Physics (#10282)
  studio: fix viewport container bg and margin (#10473)
  optimize spline helper (#10295)
  Point & Click Placement Mode (#10042)
  add postprocessing editor back (#10472)
  IR-1579-Resource-tracker (#10423)
  Ir 2790 mouseover tooltip to show fullname (#10456)

# Conflicts:
#	packages/editor/src/services/ComponentEditors.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HexaField HexaField HexaField approved these changes

@DanielBelmes DanielBelmes Awaiting requested review from DanielBelmes

Assignees

@heysokam heysokam

Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heysokam @HexaField