adding helper function hook for in-frustum #10274
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
requested changes
May 29, 2024
| @@ -227,6 +233,15 @@ export const TransformComponent = defineComponent({ | |||
| transform.matrixWorld.compose(vec3, quat, scale) | |||
| }, | |||
|
|
|||
| useInViewingFrustum: () => { | |||
There was a problem hiding this comment.
can we pass in the entity and camera instead? using useEntityContext here is indirectional, and this should be extensible to any camera
There was a problem hiding this comment.
changed this to just be a function call with params as suggested here. I don't think it being a hook is necessary in this case
HexaField
requested changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adding helper function hook for whether an entity context is in frustum of the viewer
closes #insert number here
https://tsu.atlassian.net/browse/IR-1652
QA Steps