Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused tiers indices #911

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Fix unused tiers indices #911

merged 4 commits into from
Sep 18, 2023

Conversation

karnikaavelumani
Copy link
Collaborator

Previously, the board was displayed in the order of their IDs, but this behavior was updated in this PR to reflect being displayed by the indices to allow fast updates to positions.

Files were separated to provide clarity.

Fix #904.

karnikaavelumani and others added 2 commits September 17, 2023 21:20
Co-Authored-By: Ethan Davidson <[email protected]>
Co-Authored-By: Ethan Davidson <[email protected]>
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 825f230
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/6507d35ff1e5bc000767a100
😎 Deploy Preview https://deploy-preview-911--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way you reorganized src/lib/public/board/data/index.ts ;)

Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix .github/workflows/check_website.yaml errors.

Co-Authored-By: Ethan Davidson <[email protected]>
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the speedy follow-up.

@karnikaavelumani karnikaavelumani merged commit b97ff85 into main Sep 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused tier indices
2 participants