Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified maximum width of paragraphs in homepage #729 #891

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

tomasohCHOM
Copy link
Collaborator

I set the maximum width of paragraph elements to be 50ch so that the text doesn't become to wide as the screen size gets wider. I also switched the use of pixels to character units as we are dealing with text here. Fixed #729

BEFORE AFTER
Before (Wide Screen) After (Wide Screen)
Before (Shorter Screen) After (Shorter Screen)

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 25c58d8
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/64adb6ca6ce2470008c5547d
😎 Deploy Preview https://deploy-preview-891--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; thanks for contributing! Nicely done PR 😎

@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) July 11, 2023 20:10
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Your PR is written very well. Keep up the amazing work:)

@EthanThatOneKid EthanThatOneKid merged commit 71778ff into EthanThatOneKid:main Jul 11, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragraphs on the index page are too wide
3 participants