Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added footer and navbar to layout on 404 page, add flex gap to 404 page #718

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Added footer and navbar to layout on 404 page, add flex gap to 404 page #718

merged 3 commits into from
Nov 14, 2022

Conversation

j1yl
Copy link
Collaborator

@j1yl j1yl commented Nov 14, 2022

image
image

Changes

  • Added footer and navbar to +layout.svelte
  • Added flex gap and removed margin top/bottom from +error.svelte

@netlify
Copy link

netlify bot commented Nov 14, 2022 •
edited
Loading

✅ Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 9dcc3da
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/6372b01abd7faf000800b11b
😎 Deploy Preview https://deploy-preview-718--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@j1yl j1yl linked an issue Nov 14, 2022 that may be closed by this pull request
Home Page Redirect on 404 page #688
Closed
@j1yl
Copy link
Collaborator Author

j1yl commented Nov 14, 2022

image

Changes

  • Added Button component to 404

Note

  • Button opens up a new tab because there is no prop for target attribute

karnikaavelumani
karnikaavelumani approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Congrats on your first PR! We appreciate all the hard work and hope that you continue to contribute:)

@j1yl j1yl merged commit d0c9f2f into main Nov 14, 2022
@j1yl j1yl deleted the fix/688-2 branch November 14, 2022 21:30
This was referenced Nov 14, 2022
Closed
Merged
@j1yl j1yl mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karnikaavelumani karnikaavelumani karnikaavelumani approved these changes

@EthanThatOneKid EthanThatOneKid Awaiting requested review from EthanThatOneKid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home Page Redirect on 404 page
2 participants
@j1yl @karnikaavelumani