Blog Title Overflow Fix #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @EthanThatOneKid on Vercel. @EthanThatOneKid first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stephaniePocci
requested review from
anguzz,
karnikaavelumani,
charliettaylor and
EthanThatOneKid
jaasonw
suggested changes
Sep 22, 2022
Closed
stephaniePocci
force-pushed
the
main
branch
from
0e957b6
to
444c268
Compare
karnikaavelumani
approved these changes
Sep 23, 2022
charliettaylor
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #274
I was able to fix the blog listings so that there is no more text overflow from the titles. The titles now wrap, truncate, and place ellipsis. See screenshots below:
I'm unable to show the changes in vercel since I had to enable debug mode for localhost changes, so reviewers may need to clone my fork locally to view the changes. Please feel free to let me know though if there is a way to enable the blogs to be viewed in vercel!
Also, I noticed there is another issue where the titles still do text overflow on the actual blog pages, so I will be making an issue for that soon.