-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to SvelteKit release candidate #577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `/lib/legacy` directory - Renamed `/lib/icons` to `/lib/svg` - Renamed `/lib/components/sections/navbar.svelte` to `/lib/components/nav/bar.svelte` - Renamed `/lib/stores` to `/routes/`
- Also ran format and lint
- Resolves #393 - Removed `npm run tabs` - Ran `npm run all`
commit ae536ba Author: EthanThatOneKid <[email protected]> Date: Sat Sep 10 16:36:45 2022 -0700 Update package-lock.json commit b245679 Merge: 8d1bc89 eab6434 Author: EthanThatOneKid <[email protected]> Date: Sat Sep 10 16:31:49 2022 -0700 Merge branch 'mig/index' of https://github.com/EthanThatOneKid/acmcsuf.com into mig/index commit 8d1bc89 Author: EthanThatOneKid <[email protected]> Date: Sat Sep 10 16:26:14 2022 -0700 You may install up to 256 MB to render this static website 😎 commit eab6434 Author: EthanThatOneKid <[email protected]> Date: Sat Sep 10 16:26:14 2022 -0700 You may install up to 256 MB to render this static website 😎 commit 6e061e2 Author: EthanThatOneKid <[email protected]> Date: Sat Sep 10 16:19:45 2022 -0700 `npm i @size-limit/file` commit 76b7cae Author: EthanThatOneKid <[email protected]> Date: Sat Sep 10 16:11:37 2022 -0700 `npm i -D size-limit`
- Moved [`src/lib/components/privacy/privacy-policy.svelte`](https://github.com/EthanThatOneKid/acmcsuf.com/blob/36d15b5cdf373b3c594c773ebf3b3942e54677c6/src/lib/components/privacy/privacy-policy.svelte) to `src/routes/privacy/policy.svelte`.
- Resolved errors in `quiz.svelte` refactor
TODO: Update test events data
- Ran `npm i `svelte-confetti` - Added existing code from #537
This was referenced Sep 22, 2022
EthanThatOneKid
commented
Sep 22, 2022
EthanThatOneKid
commented
Sep 22, 2022
karnikaavelumani
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This was referenced Sep 22, 2022
This was referenced Sep 22, 2022
karnikaavelumani
added a commit
that referenced
this pull request
Sep 22, 2022
karnikaavelumani
added a commit
that referenced
this pull request
Sep 22, 2022
This was referenced Oct 7, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration guide: sveltejs/kit#5774
What this PR accomplishes
npm create svelte@latest acmcsuf.com
(ran on 9/10/22)/src/lib/
to/routes/
directory. Introduction of/lib/public/legacy/
for extraneous files./
and/static/
/
index page/src/service-worker/
(https://kit.svelte.dev/docs/service-workers)/src/params/
(https://kit.svelte.dev/docs/advanced-routing#matching)/src/routes/+error.svelte
(https://kit.svelte.dev/docs/routing#error)What this PR consists of
This mega-PR consists of the following smaller PRs:
Resolves #502.