-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced old 404 image with blank frank picture and text #458
Conversation
So I used the blank lost frank image and added a 404 error message above it and made it work in mobile and desktop settings. I did not add the question mark above Frank's head like the original but it is functional.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@jaasonw made the gap smaller due to suggestion
I changed the space to 0.5em, aligned the text center to fix the problem, and left the text as default font so it would go to Poppins by itself since I think that's our default
accidentally included this
Added margin top in order to fix issue where text from 404 was not showing up in minimized view
Minimized view looked squished so it needed more margin on the bottom so we added 3em margin bottom to give it some space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on finishing up with finals; phew! Managed to take a look at your PR again and added some minor suggestions. Progress looks great so far! Thanks for contributing :)
Co-authored-by: Ethan Davidson <[email protected]>
Co-authored-by: Ethan Davidson <[email protected]>
Co-authored-by: Ethan Davidson <[email protected]>
Co-authored-by: Ethan Davidson <[email protected]>
Congrats to you as well, had a good time learning the ropes with this issue. Let me know if there are any other problems with it |
Changes look good and the fix looks like it works in desktop, mobile, and minimized view.
text shadow was made lighter as suggested and font-weight was added, suggested by @EthanThatOneKid
Basically, I did the thingy with the thongy and used the blank Frank picture that Mike gave me with a 404 error message above it to fix the issue. It works on both mobile and desktop after doing some magic wizard stuff. I think it works alright. I apologize to Mike in advance because there is no question mark above Frank's head like in the original photo but I think he will find it in his heart to forgive me.