Replaced old 404 image with blank frank picture and text #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I used the blank lost frank image and added a 404 error message above it and made it work in mobile and desktop settings. I did not add the question mark above Frank's head like the original but it is functional.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
@jaasonw made the gap smaller due to suggestion
|
|
to reiterate what i said on discord a. need text-align: center |
I changed the space to 0.5em, aligned the text center to fix the problem, and left the text as default font so it would go to Poppins by itself since I think that's our default
accidentally included this
|
|
|
|
Added margin top in order to fix issue where text from 404 was not showing up in minimized view
jaasonw
previously requested changes
May 9, 2022
jaasonw
changed the title
Minimized view looked squished so it needed more margin on the bottom so we added 3em margin bottom to give it some space
EthanThatOneKid
previously requested changes
May 22, 2022
Co-authored-by: Ethan Davidson <[email protected]>
Co-authored-by: Ethan Davidson <[email protected]>
Co-authored-by: Ethan Davidson <[email protected]>
Co-authored-by: Ethan Davidson <[email protected]>
Congrats to you as well, had a good time learning the ropes with this issue. Let me know if there are any other problems with it |
Changes look good and the fix looks like it works in desktop, mobile, and minimized view.
text shadow was made lighter as suggested and font-weight was added, suggested by @EthanThatOneKid
karnikaavelumani
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, I did the thingy with the thongy and used the blank Frank picture that Mike gave me with a 404 error message above it to fix the issue. It works on both mobile and desktop after doing some magic wizard stuff. I think it works alright. I apologize to Mike in advance because there is no question mark above Frank's head like in the original photo but I think he will find it in his heart to forgive me.