Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officer Automation: Disabled issue closing and minor bugfixes #301

Merged
merged 4 commits into from
Feb 19, 2022

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Feb 19, 2022

There are a couple minor tweaks needed by our officer automation. When running #299, I noticed that the "Term" field was not to be left empty. This is unexpected behavior since we may merely wish to update the officer's image.

  • Disable automatic issue closing; allow the user to close the issue by merging the generated PR
  • Add a new line at the end of the JSON output for officers.json to comply with our linter
  • Disable "Term" as a required field

@EthanThatOneKid EthanThatOneKid added devops Some operation must be executed bugfix A PR that fixes a bug labels Feb 19, 2022
@vercel
Copy link

vercel bot commented Feb 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/BwyzqMss8qe7y9vNtNcjr35iaSbV
✅ Preview: https://acm-csuf-site-git-ethanthatonekid-patch-4-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview February 19, 2022 07:17 Inactive
@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review February 19, 2022 07:18
@EthanThatOneKid EthanThatOneKid requested a review from a user February 19, 2022 07:19
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the code, LGTM

@vercel vercel bot temporarily deployed to Preview February 19, 2022 07:33 Inactive
@EthanThatOneKid EthanThatOneKid added the documentation Improvements or additions to documentation label Feb 19, 2022
@EthanThatOneKid EthanThatOneKid merged commit a0547ca into main Feb 19, 2022
@jaasonw jaasonw deleted the EthanThatOneKid-patch-4 branch February 21, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug devops Some operation must be executed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant