Improvements to app docs #185
Conversation
Co-authored-by: Mike Wilburn <[email protected]>
maps-app/build.gradle
Outdated
| versionCode = 1 | ||
| versionName = '1.0.8' |
There was a problem hiding this comment.
According to Android's documentation, I don't think we need the = signs here:
| versionCode = 1 | |
| versionName = '1.0.8' | |
| versionCode 1 | |
| versionName '1.0.8' |
There was a problem hiding this comment.
I'd like to keep as-is. This file was auto-generated by Android Studio.
There was a problem hiding this comment.
Are you on the latest version of Android Studio ? if not it might be the reason why auto-generation did it that way.
There was a problem hiding this comment.
Or may be older gradle plugin.
There was a problem hiding this comment.
When prompted to update, i'm provided this information:
To take advantage of the latest features, improvements, and security fixes, we strongly recommend that you update the Android Gradle plugin from the current version 3.3.2 to version 3.6.3 and Gradle to version 5.6.4.
Updating now.
There was a problem hiding this comment.
I've updated Android Studio and gradle, there was no error thrown with keeping = as-is. With that said, the Android documentation suggests a format without the =. So, i've updated the gradle file accordingly.
|
@puneet-pdx are we good to go here? |
This PR:
docs/index.mdtodocs/README.md@puneet-pdx i'm additionally requesting your review to ensure i've properly updated the app version number in the project.