Add curl speed limit for low bandwidth server #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikMinekus
requested changes
Aug 14, 2020
| {"HTTPClient.MaxSendSpeed.get", GetClientMaxSendSpeed}, | ||
| {"HTTPClient.MaxSendSpeed.set", SetClientMaxSendSpeed}, | ||
| {"HTTPClient.MaxRecvSpeed.get", GetClientMaxRecvSpeed}, | ||
| {"HTTPClient.MaxRecvSpeed.set", SetClientMaxRecvSpeed}, |
There was a problem hiding this comment.
You need to add these properties to the HTTPClient methodmap in http.inc as well.
Preferably with documentation indicating that the value is in bytes/sec.
httpfilecontext.cpp
Outdated
| } | ||
| if (maxSendSpeed > 0) | ||
| { | ||
| curl_easy_setopt(curl, CURLOPT_MAX_RECV_SPEED_LARGE, maxSendSpeed); |
There was a problem hiding this comment.
CURLOPT_MAX_SEND_SPEED_LARGE
httpfilecontext.h
Outdated
| @@ -49,6 +50,8 @@ class HTTPFileContext : public IHTTPContext | |||
| long connectTimeout; | |||
| long followLocation; | |||
| long timeout; | |||
| long maxSendSpeed; | |||
| long maxRecvSpeed; | |||
There was a problem hiding this comment.
According to the cURL documentation these should be of type curl_off_t.
There was a problem hiding this comment.
yeap, i will change it later, curl_off_t is int64_t I think.
peace-maker
reviewed
Aug 14, 2020
| @@ -174,4 +174,16 @@ methodmap HTTPClient < Handle | |||
| public native get(); | |||
| public native set(int timeout); | |||
| } | |||
|
|
|||
| // Max Send speed in bytes per seconed. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.