Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add int64 support #26

Merged
merged 6 commits into from
Jul 11, 2020
Merged

Add int64 support #26

merged 6 commits into from
Jul 11, 2020

Conversation

gunslinger23
Copy link
Contributor

@gunslinger23 gunslinger23 commented Jul 7, 2020

Changed

  1. Add Object & Array 64-bit int support (Set/Get/Push to array)
  2. Fix warnings of type conversion
  3. Update testing plugin

Already test in game! 👌

@gunslinger23
Copy link
Contributor Author

ripext-test

@ErikMinekus
Copy link
Owner

ErikMinekus commented Jul 7, 2020

Thanks! Can you add JSONArray.PushInt64() as well?

@gunslinger23
Copy link
Contributor Author

Thanks! Can you add JSONArray.PushInt64() as well?

Sure, I almost forgot it 😂

Add PushInt64 method for array
Update testing plugin
@gunslinger23
Copy link
Contributor Author

Testing POST Response:

{
    "args": {},
    "data": "{\"id\": 1, \"int64\": 9223372036854775800, \"jsonrpc\": 2.0, \"bool\": true, \"method\": \"subtract\", \"null\": null, \"params\": [{\"id\": 1}, 1, 9223372036854775800, 2.0, true, \"string\", null]}",
    "files": {},
    "form": {},
    "headers": {
        "Accept": "application/json",
        "Accept-Encoding": "deflate, gzip",
        "Content-Type": "application/json",
        "Host": "nghttp2.org",
        "Transfer-Encoding": "chunked"
    },
    "json": {
        "bool": true,
        "id": 1,
        "int64": 9223372036854775800,
        "jsonrpc": 2.0,
        "method": "subtract",
        "null": null,
        "params": [
            {
                "id": 1
            },
            1,
            9223372036854775800,
            2.0,
            true,
            "string",
            null
        ]
    },
    "origin": "",
    "url": "https://nghttp2.org/httpbin/post"
}

@gunslinger23
Copy link
Contributor Author

@ErikMinekus It's ready for merge 😉

@ErikMinekus ErikMinekus merged commit 5c6b22c into ErikMinekus:master Jul 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants