-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Abbreviate commit_sha to be back to being the short SHA #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndBug
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! Thanks for catching that ✨
@all-contributors please add @DenverCoder1 for their bug report and code contribution ;) |
I've put up a pull request to add @DenverCoder1! 🎉 |
MaxymVlasov
pushed a commit
to SpotOnInc/renovate-config
that referenced
this pull request
Jun 7, 2023
### Release Notes <details> <summary>EndBug/add-and-commit</summary> ### [`v9.1.3`](https://togithub.com/EndBug/add-and-commit/releases/tag/v9.1.3) [Compare Source](https://togithub.com/EndBug/add-and-commit/compare/v9.1.2...v9.1.3) #### What's Changed - chore(deps-dev): bump all-contributors-cli from 6.24.0 to 6.25.0 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#504 - chore(deps): bump simple-git by [@​EndBug](https://togithub.com/EndBug) in [EndBug/add-and-commit#505 **Full Changelog**: EndBug/add-and-commit@v9.1.2...v9.1.3 ### [`v9.1.2`](https://togithub.com/EndBug/add-and-commit/releases/tag/v9.1.2) [Compare Source](https://togithub.com/EndBug/add-and-commit/compare/v9.1.1...v9.1.2) #### What's Changed - Update `io.ts` by [@​ggreif](https://togithub.com/ggreif) in [EndBug/add-and-commit#443 - docs: add ggreif as a contributor for maintenance by [@​allcontributors](https://togithub.com/allcontributors) in [EndBug/add-and-commit#444 - chore(deps-dev): bump all-contributors-cli from 6.23.1 to 6.24.0 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#445 - fix(io): add warning for pull input by [@​EndBug](https://togithub.com/EndBug) in [EndBug/add-and-commit#453 - Fix a few typos in `README.md` by [@​ggreif](https://togithub.com/ggreif) in [EndBug/add-and-commit#454 - docs: add ggreif as a contributor for doc by [@​allcontributors](https://togithub.com/allcontributors) in [EndBug/add-and-commit#456 - Typo in `io.ts` debug output by [@​ggreif](https://togithub.com/ggreif) in [EndBug/add-and-commit#455 - chore(deps-dev): bump husky from 8.0.1 to 8.0.2 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#457 - chore(deps): bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#458 - chore(deps-dev): bump typescript from 4.8.4 to 4.9.3 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#460 - chore(deps-dev): bump prettier from 2.7.1 to 2.8.0 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#461 - chore(deps-dev): bump [@​vercel/ncc](https://togithub.com/vercel/ncc) from 0.34.0 to 0.36.0 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#462 - chore(deps-dev): bump prettier from 2.8.0 to 2.8.1 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#463 - chore(deps-dev): bump typescript from 4.9.3 to 4.9.4 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#464 - chore(deps-dev): bump prettier from 2.8.1 to 2.8.2 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#470 - chore(deps-dev): bump eslint-config-prettier from 8.5.0 to 8.6.0 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#471 - chore(deps-dev): bump husky from 8.0.2 to 8.0.3 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#472 - chore(deps-dev): bump prettier from 2.8.2 to 2.8.3 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#474 - Add how to autodetect deleted files by [@​azeemba](https://togithub.com/azeemba) in [EndBug/add-and-commit#468 - chore(deps-dev): bump [@​vercel/ncc](https://togithub.com/vercel/ncc) from 0.36.0 to 0.36.1 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#475 - chore(deps-dev): bump typescript from 4.9.4 to 4.9.5 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#477 - chore(deps-dev): bump prettier from 2.8.3 to 2.8.4 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#480 - docs: add keithrfung as a contributor for doc by [@​allcontributors](https://togithub.com/allcontributors) in [EndBug/add-and-commit#482 - chore(deps-dev): bump eslint-config-prettier from 8.6.0 to 8.7.0 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#484 - chore(deps-dev): bump prettier from 2.8.4 to 2.8.5 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#487 - chore(deps-dev): bump typescript from 4.9.5 to 5.0.2 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#488 - chore(deps-dev): bump prettier from 2.8.5 to 2.8.7 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#490 - chore(deps-dev): bump eslint-config-prettier from 8.7.0 to 8.8.0 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#489 - chore(deps-dev): bump typescript from 5.0.2 to 5.0.3 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#493 - chore(deps-dev): bump typescript from 5.0.3 to 5.0.4 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#494 - chore(deps-dev): bump prettier from 2.8.7 to 2.8.8 by [@​dependabot](https://togithub.com/dependabot) in [EndBug/add-and-commit#500 - fix: Abbreviate commit_sha to be back to being the short SHA by [@​DenverCoder1](https://togithub.com/DenverCoder1) in [EndBug/add-and-commit#502 - docs: add DenverCoder1 as a contributor for bug, and code by [@​allcontributors](https://togithub.com/allcontributors) in [EndBug/add-and-commit#503 #### New Contributors - [@​ggreif](https://togithub.com/ggreif) made their first contribution in [EndBug/add-and-commit#443 - [@​azeemba](https://togithub.com/azeemba) made their first contribution in [EndBug/add-and-commit#468 - [@​DenverCoder1](https://togithub.com/DenverCoder1) made their first contribution in [EndBug/add-and-commit#502 **Full Changelog**: EndBug/add-and-commit@v9.1.1...v9.1.2 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501
In
Simple Git 3.6.0
, the default value ofcommit
was changed to be the full commit instead of the short 7 character SHA. This causes thecommit_sha
andcommit_long_sha
to return the same value instead ofcommit_sha
being the 7-character abbreviated version as it says in the docs.This change makes
commit_long_sha
use the SHA from Simple Git and abbreviatescommit_sha
to a maximum of 7 characters.