Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions on how to user a different user #140

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Conversation

rugk
Copy link
Contributor

@rugk rugk commented Feb 9, 2021

grafik

Unfortunately, still a little grey… but uhm… dunno, it's the official mail/creds they state in their Readme.

If you know a better way, let me know.

@EndBug EndBug self-assigned this Feb 9, 2021
@EndBug EndBug added the type: docs Documentation changes label Feb 9, 2021
@EndBug EndBug added this to In progress in Main board via automation Feb 9, 2021
@EndBug
Copy link
Owner

EndBug commented Feb 13, 2021

That is just the picture that GitHub uses for any unknown user, so even if you use [email protected] the logo should be the same.
An alternative would be using [email protected], which I think it's the official placeholder account, since it's been reserved by GItHub. As you can see from the profile, it has the actions logo but it's cropped, so I wouldn't advise using it. Also, if you use this email GitHub will always show actions-user as the author name, even if the commit is signed with another name.

Unless we find a better alternative, I think it's better if we just leave it as it is.

@rugk
Copy link
Contributor Author

rugk commented Feb 14, 2021

Well… then I wonder why they did suggest this different mail in their own example.
Whether to use [email protected] or [email protected] hardly makes a difference I guess, so if the latter shows the proper avatar, why not use [email protected]?

I see nothing wrong with that. (Semantically) It's the user who committed it.

But it seems we're not the first one to have this issue: ad-m/github-push-action@2753077

The investigation there turned out your mail also does not work. It needs to be 41898282+github-actions[bot]@users.noreply.github.com. Should I adjust that?

@EndBug
Copy link
Owner

EndBug commented Feb 14, 2021

41898282+github-actions[bot]@users.noreply.github.com seems great to me! If you can edit the example to feature this email it's ready to merge. Also, explain that this will show the GitHub logo ;)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@EndBug EndBug merged commit 7451ee8 into EndBug:master Feb 17, 2021
Main board automation moved this from In progress to Done Feb 17, 2021
@rugk rugk deleted the patch-2 branch February 17, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Documentation changes
Projects
No open projects
Main board
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants