Added optional token bundling in change #525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tx_builder.add_bundled_change_if_needed than takes a max tokens bundle size parameter. This allows to split the change output into multiple outputs based on a fixed number of NFTs. Updated the (admittedly quite stale) example/index.ts and added a relevant test to example/index.spec.ts
|
Tiny bit of context for the example/ changes: the section didn't build, it was trying to compare a mainnet address to a testnet address in the address test and all-in-all needed some work so that I could do an e2e test for my function. |
|
Thanks @nicolasayotte ! We will review your PR : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tx_builder.add_bundled_change_if_needed than takes a max tokens bundle size parameter. This allows to split the change output into multiple outputs based on a fixed number of NFTs.
Updated the (admittedly quite stale) example/index.ts and added a relevant test to example/index.spec.ts